build: avoid compiling with VS v17.12 #55930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanStojanovic
added
windows
richardlau
approved these changes
Nov 20, 2024
lpinca
approved these changes
Nov 20, 2024
jakecastelli
approved these changes
Nov 21, 2024
jasnell
approved these changes
Nov 23, 2024
jasnell
reviewed
Nov 23, 2024
| if %errorlevel% neq 1 ( | ||
| @rem Clang 18.1.8 Provided with VS 17.12 works fine. | ||
| if not defined clang_cl ( | ||
| echo Node.js doesn't compile with Visual Studio 17.12 Please use a different version. |
There was a problem hiding this comment.
Including a link to an issue that describes the reason for this would be helpful.
There was a problem hiding this comment.
Hey @jasnell thanks for the suggestion. That makes a lot of sense. However, you've already approved this, the CI has finished, and based on the MSFT issue the reason behind it is fixed and pending release. I assume this will be in some 17.12.x release, so I'll most likely end up reverting this then. With all that in mind, would you oppose me landing this PR as is?
github-actions
bot
removed
the
request-ci
StefanStojanovic
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 542f252 |
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
Refs: nodejs/build#3963 PR-URL: #55930 Refs: #53863 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio v17.12 has a bug that produces a compilation error. Since ClangCL is now supported as a compiler for Node.js on Windows, and Clang 18.1.8, provided with VS 17.12, works fine, Only MSVC is disabled.
cc @nodejs/platform-windows @nodejs/build @huseyinacacak-janea
Refs: nodejs/build#3963
Refs: #53863